View Javadoc
1   package org.apache.maven.it;
2   
3   /*
4    * Licensed to the Apache Software Foundation (ASF) under one
5    * or more contributor license agreements.  See the NOTICE file
6    * distributed with this work for additional information
7    * regarding copyright ownership.  The ASF licenses this file
8    * to you under the Apache License, Version 2.0 (the
9    * "License"); you may not use this file except in compliance
10   * with the License.  You may obtain a copy of the License at
11   *
12   *   http://www.apache.org/licenses/LICENSE-2.0
13   *
14   * Unless required by applicable law or agreed to in writing,
15   * software distributed under the License is distributed on an
16   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
17   * KIND, either express or implied.  See the License for the
18   * specific language governing permissions and limitations
19   * under the License.
20   */
21  
22  import org.apache.maven.it.util.ResourceExtractor;
23  
24  import java.io.File;
25  import java.util.Properties;
26  
27  /**
28   * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-2972">MNG-2972</a>.
29   *
30   * @author Benjamin Bentmann
31   *
32   */
33  public class MavenITmng2972OverridePluginDependencyTest
34      extends AbstractMavenIntegrationTestCase
35  {
36  
37      public MavenITmng2972OverridePluginDependencyTest()
38      {
39          super( "(2.0.8,)" );
40      }
41  
42      /**
43       * Verify that a project-level plugin dependency replaces the original dependency from the plugin POM.
44       *
45       * @throws Exception in case of failure
46       */
47      public void testitLifecycleInvocation()
48          throws Exception
49      {
50          File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-2972/test1" );
51          Verifier verifier = newVerifier( testDir.getAbsolutePath() );
52          verifier.setAutoclean( false );
53          verifier.deleteDirectory( "target" );
54          verifier.deleteArtifact( "org.apache.maven.its.plugins.class-loader", "dep-b", "0.2-mng-2972", "jar" );
55          verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", verifier.newDefaultFilterProperties() );
56          verifier.addCliOption( "--settings" );
57          verifier.addCliOption( "settings.xml" );
58          verifier.executeGoal( "validate" );
59          verifier.verifyErrorFreeLog();
60          verifier.resetStreams();
61  
62          Properties pclProps = verifier.loadProperties( "target/pcl.properties" );
63          verify( pclProps );
64      }
65  
66      /**
67       * Verify that a project-level plugin dependency replaces the original dependency from the plugin POM.
68       * Apart from testing direct CLI invocation this time, this test also employs a slightly different version for the
69       * overriding dependency. The original bug is caused by usage of a HashSet but whenever the random order of its
70       * elements happens to match the correct ordering, the test cannot detect the bad implementation. The obvious way
71       * to increase the test coverage is re-running the test with different dependency versions, each time producing
72       * another hash code for the dependency artifact and thereby changing its position in the HashSet's element order.
73       * The two versions 0.2-mng-2972 and 9.9-MNG-2972 we use here have at least once proven (on Sun JDK 1.6.0_07) to
74       * successfully break the correctness of the random ordering.
75       *
76       * @throws Exception in case of failure
77       */
78      public void testitCommandLineInvocation()
79          throws Exception
80      {
81          File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-2972/test2" );
82          Verifier verifier = newVerifier( testDir.getAbsolutePath() );
83          verifier.setAutoclean( false );
84          verifier.deleteDirectory( "target" );
85          verifier.deleteArtifact( "org.apache.maven.its.plugins.class-loader", "dep-b", "9.9-MNG-2972", "jar" );
86          verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", verifier.newDefaultFilterProperties() );
87          verifier.addCliOption( "--settings" );
88          verifier.addCliOption( "settings.xml" );
89          verifier.executeGoal( "org.apache.maven.its.plugins:maven-it-plugin-class-loader:2.1-SNAPSHOT:load" );
90          verifier.verifyErrorFreeLog();
91          verifier.resetStreams();
92  
93          Properties pclProps = verifier.loadProperties( "target/pcl.properties" );
94          verify( pclProps );
95      }
96  
97      private void verify( Properties pclProps )
98          throws Exception
99      {
100         assertNotNull( pclProps.getProperty( "org.apache.maven.its.mng2972.MNG2972" ) );
101         assertNull( pclProps.getProperty( "org.apache.maven.plugin.coreit.ClassA" ) );
102         assertNull( pclProps.getProperty( "org.apache.maven.plugin.coreit.ClassB" ) );
103         assertEquals( "1", pclProps.getProperty( "org/apache/maven/its/mng2972/mng-2972.properties.count" ) );
104         assertEquals( "0", pclProps.getProperty( "org/apache/maven/plugin/coreit/a.properties.count" ) );
105         assertEquals( "0", pclProps.getProperty( "org/apache/maven/plugin/coreit/b.properties.count" ) );
106     }
107 
108 }